-
Notifications
You must be signed in to change notification settings - Fork 43.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dx): add a code-workspace for vscode #7285
base: master
Are you sure you want to change the base?
Conversation
PR Description updated to latest commit (8120b4e)
|
PR Reviewer Guide 🔍
|
✅ Deploy Preview for auto-gpt-docs canceled.
|
PR Code Suggestions ✨
|
}, | ||
"extensions": { | ||
"recommendations": [ | ||
"charliermarsh.ruff", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one of the 5 projects in the repo currently uses Ruff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each project uses diff things. Might as well suggest what we have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this file cause Ruff to make all kinds of automatic changes, even in projects that don't use Ruff?
"recommendations": [ | ||
"charliermarsh.ruff", | ||
"dart-code.flutter", | ||
"ms-python.black-formatter", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ruff + Black?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some use ruff some use black
"ms-python.vscode-pylance", | ||
"prisma.prisma", | ||
"qwtel.sqlite-viewer", | ||
"joshx.workspace-terminals" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VSCode already lets you choose when opening a terminal. If we have 10 folders by default I don't want it to open up 10 terminals on start-up, because there is no way I'll actually be working on all 10 folders at the same time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh lol there’s a setting to disable that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then what's the point of the extension? Afaics that's the only thing it does.
"python.analysis.inlayHints.callArgumentNames": "partial", | ||
"python.analysis.fixAll": [ | ||
"source.convertImportFormat", | ||
"source.unusedImports" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is actually quite annoying imo, because if you add an import with the intention of using it later and you hit save, the import disappears.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing it is fine with me, just make the commits as I’m OOO for the next week or so. The workspace splitting and extension recommendations matter here more imo. Each project will probably have its own settings
Co-authored-by: Reinier van der Leer <[email protected]>
{ | ||
"name": ".github", | ||
"path": "../.github" | ||
}, | ||
{ | ||
"name": ".vscode", | ||
"path": "../.vscode" | ||
}, | ||
{ | ||
"name": "assets", | ||
"path": "../assets" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These don't need separate interpreters or environments so can be covered by the root folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair drop them
Co-authored-by: Reinier van der Leer <[email protected]>
User description
Background
Developing autogpt is kinda a pain rn across all the different services. This allows you to have segmented terminals for each that don't try and activate weird poetry envs automatically
Changes 🏗️
PR Quality Scorecard ✨
+2 pts
+5 pts
+5 pts
+5 pts
-4 pts
+4 pts
+5 pts
-5 pts
agbenchmark
to verify that these changes do not regress performance?+10 pts
PR Type
Enhancement, Configuration changes
Description
Changes walkthrough 📝
autogpt-workspace.code-workspace
Add VSCode workspace configuration for AutoGPT project
.vscode/autogpt-workspace.code-workspace
workspace terminals.